chore(deps) : Upgrade to spring 4 #2079

rajadilipkolli · 2025-10-02T15:30:15Z

Summary by CodeRabbit

New Features
- Added OpenTelemetry-based observability for tracing and metrics.
Bug Fixes
- Fixed Grafana datasource YAML structure and regex quoting.
- Updated Grafana README credentials to admin/admin.
Chores
- Upgraded Java runtime to 25 in CI/workflows.
- Bumped framework baseline to Spring Boot 4.0.0-M3 and aligned web/AOP starters.
- Added Kotlin reflection and updated code formatter version.
- Adjusted tests for an updated JSON library package.
- Added a Java IDE launch configuration.

coderabbitai · 2025-10-02T15:30:23Z

Walkthrough

Updates CI and project Java version to 25, upgrades Spring Boot parent to 4.0.0-M3, adjusts dependencies (AspectJ, WebMVC, OpenTelemetry, kotlin-reflect), fixes a Jackson import in tests, adds a VSCode launch entry, fixes Grafana datasource YAML structure, and changes Grafana credentials in the README.

Changes

Cohort / File(s)	Summary of Changes
CI Java Runtime `.github/workflows/boot-strategy-plugin.yml`	GraalVM setup now uses Java 25 instead of 21.
Build & Dependencies `boot-strategy-plugin/pom.xml`	Parent upgraded to `4.0.0-M3`; `java.version` → 25; `spring-boot-starter-aop` → `spring-boot-starter-aspectj`; `spring-boot-starter-web` → `spring-boot-starter-webmvc`; added `kotlin-reflect` and `spring-boot-starter-opentelemetry`; bumped google-java-format to 1.28.0.
Test Import `boot-strategy-plugin/src/test/java/.../StrategyPluginApplicationTests.java`	Import changed from `com.fasterxml.jackson.databind.JsonNode` to `tools.jackson.databind.JsonNode`.
Editor Launch Config `.vscode/launch.json`	Added a VSCode Java launch configuration entry for the Strategy Plugin application.
Docs / Credentials `boot-strategy-plugin/ReadMe.md`	Grafana credentials updated from `user/password` to `admin/admin`.
Grafana Provisioning `boot-strategy-plugin/platform/grafana/provisioning/datasources/datasource.yml`	Corrected YAML nesting: moved `derivedFields` under `jsonData` with proper indentation and structure; ensured `matcherRegex` and related fields are properly quoted/structured.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

chore(deps) : Upgrade to spring boot 4.0.0 #1978 — Similar Spring Boot 4 parent upgrade and addition of OpenTelemetry dependency.
feat : convert to maven build #1579 — Related changes to Maven build configuration and CI Java version for the boot-strategy-plugin.
chore(deps) : Upgrade to spring boot 4 #1977 — Another Spring Boot 4 upgrade PR touching parent and dependency adjustments.

Poem

I nibble at XML and hop through trees,
Java twenty-five upon the breeze.
Parents lifted, aspects in tow,
Grafana tuned, the dashboards glow.
A carrot for CI — hop, code, and go! 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly conveys the primary change of upgrading the project dependency to Spring 4, which aligns with the main modification of bumping the Spring Boot parent POM to version 4.0.0-M3, and it follows a clear and concise conventional commit format without extraneous detail.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch strategy

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb6b16f and 5d09974.

📒 Files selected for processing (1)

boot-strategy-plugin/platform/grafana/provisioning/datasources/datasource.yml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

boot-strategy-plugin/platform/grafana/provisioning/datasources/datasource.yml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Codacy Static Code Analysis

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d09f78 and 4ff3bc7.

📒 Files selected for processing (3)

.github/workflows/boot-strategy-plugin.yml (1 hunks)
boot-strategy-plugin/pom.xml (5 hunks)
boot-strategy-plugin/src/test/java/com/example/plugin/strategyplugin/StrategyPluginApplicationTests.java (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: Codacy Static Code Analysis
GitHub Check: Run Unit & Integration Tests

🔇 Additional comments (8)

.github/workflows/boot-strategy-plugin.yml (1)

39-39: LGTM! Java version upgraded to 25.

The GraalVM setup now uses Java 25, which aligns with the project-wide upgrade to Spring Boot 4.0.0-M3 and Java 25 in the pom.xml.

boot-strategy-plugin/pom.xml (7)

8-8: Spring Boot 4.0.0-M3 is a milestone release.

The upgrade to Spring Boot 4.0.0-M3 is a significant step forward. Note that this is a milestone (pre-release) version, which may contain breaking changes and is not recommended for production use until a stable release is available.

56-60: Clarify the kotlin-reflect dependency comment.

The comment states "to be removed when SB4 is supported," but this PR is already upgrading to Spring Boot 4.0.0-M3. Please clarify:

Is this dependency needed as a temporary workaround for a milestone release issue?

Should the comment reference a specific Spring Boot 4 GA (General Availability) version?

Is there a GitHub issue or documentation explaining why kotlin-reflect is required?

69-72: LGTM! OpenTelemetry starter added.

The spring-boot-starter-opentelemetry dependency has been added, which will provide auto-configuration for OpenTelemetry integration alongside the existing tracing dependencies.

132-132: Approve bump to google-java-format 1.28.0 It supports Java 25 syntax when run on JDK ≥ 25 (minimum runtime Java 17).

16-16: Upgrade to Java 25 approved. Java 25 reached GA on September 16, 2025 and is a Long-Term Support release.

39-39: Approve AOP starter rename
The rename from spring-boot-starter-aop to spring-boot-starter-aspectj is documented in the Spring Boot 4 migration guide. Confirm whether you require AspectJ weaving (keep this starter) or only proxy-based AOP (remove it), then run tests to verify AOP behavior.

47-47: Replace spring-boot-starter-web with spring-boot-starter-webmvc per Spring Boot 4 migration guide
This update aligns with the official migration guidance. Verify your dependency tree (MVC starters no longer auto-included) and run your web tests to confirm functionality.

coderabbitai · 2025-10-02T15:35:19Z

...y-plugin/src/test/java/com/example/plugin/strategyplugin/StrategyPluginApplicationTests.java

 import org.springframework.http.MediaType;
 import org.springframework.http.ProblemDetail;
 import org.springframework.web.client.RestClient;
+import tools.jackson.databind.JsonNode;


🛠️ Refactor suggestion | 🟠 Major

🧩 Analysis chain

LGTM! Jackson 3.x package migration.

The import has been correctly updated from com.fasterxml.jackson.databind.JsonNode to tools.jackson.databind.JsonNode to align with Jackson 3.x, which is included in Spring Boot 4.0.0-M3.

Verify that all other Jackson imports across the codebase have been migrated to the new tools.jackson package:

🏁 Script executed:

#!/bin/bash # Description: Find any remaining imports from the old com.fasterxml.jackson package. # Search for old Jackson imports that should be migrated rg -n "import com\.fasterxml\.jackson\." --type=java

Length of output: 16871

Migrate all remaining Jackson imports to tools.jackson
Detected numerous import com.fasterxml.jackson.* statements across tests and main sources (e.g., scheduler, r2dbc, jpa, graphql modules). Update all to tools.jackson.* to complete the Jackson 3.x migration.

🤖 Prompt for AI Agents

In boot-strategy-plugin/src/test/java/com/example/plugin/strategyplugin/StrategyPluginApplicationTests.java around line 16, replace the existing Jackson import with the tools.jackson package (e.g., change import com.fasterxml.jackson.* to import tools.jackson.*); update this file's import to tools.jackson.databind.JsonNode and then search the repository for any remaining com.fasterxml.jackson imports and replace them with the corresponding tools.jackson.* equivalents, re-run the build/tests to ensure no remaining compilation errors and fix any updated package/API differences.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

boot-strategy-plugin/ReadMe.md (1)
28-28: Wrap Grafana URL to satisfy markdownlint.

markdownlint (MD034) dislikes bare URLs. Converting this to a Markdown link keeps the change lint-clean.

Apply this diff:
-* Grafana: http://localhost:3000/ (admin/admin)
+* Grafana: [http://localhost:3000/](http://localhost:3000/) (admin/admin)

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4ff3bc7 and eb6b16f.

📒 Files selected for processing (3)

.vscode/launch.json (1 hunks)
boot-strategy-plugin/ReadMe.md (1 hunks)
boot-strategy-plugin/platform/grafana/provisioning/datasources/datasource.yml (1 hunks)

🧰 Additional context used

🪛 markdownlint-cli2 (0.18.1)

boot-strategy-plugin/ReadMe.md

28-28: Bare URL used

(MD034, no-bare-urls)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Codacy Static Code Analysis

🔇 Additional comments (1)

.vscode/launch.json (1)

295-304: Nice addition for local debugging.

Matching the existing launch format keeps tooling consistent; no issues spotted.

boot-strategy-plugin/platform/grafana/provisioning/datasources/datasource.yml

chore(deps) : Upgrade to spring 4

4ff3bc7

rajadilipkolli self-assigned this Oct 2, 2025

github-actions bot added type: dependency-upgrade Pull requests that update a dependency file component: strategy-plugin labels Oct 2, 2025

coderabbitai bot reviewed Oct 2, 2025

View reviewed changes

attempt to fix issue with traceId

eb6b16f

coderabbitai bot reviewed Oct 2, 2025

View reviewed changes

boot-strategy-plugin/platform/grafana/provisioning/datasources/datasource.yml Show resolved Hide resolved

rajadilipkolli added 2 commits October 2, 2025 16:27

fix : json data

5d09974

Merge branch 'main' into strategy

66efd55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(deps) : Upgrade to spring 4 #2079

chore(deps) : Upgrade to spring 4 #2079

Uh oh!

rajadilipkolli commented Oct 2, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Oct 2, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Oct 2, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chore(deps) : Upgrade to spring 4 #2079

Are you sure you want to change the base?

chore(deps) : Upgrade to spring 4 #2079

Uh oh!

Conversation

rajadilipkolli commented Oct 2, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

rajadilipkolli commented Oct 2, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 2, 2025 •

edited

Loading