Skip to content

Conversation

@aurelien-roy
Copy link
Contributor

@aurelien-roy aurelien-roy commented Dec 20, 2019

This PR moves every string from template files into lang files enabling front localization.

It doesn't include mail template localization (cf #402 (comment)_ )
Closes #402

@daftspunk
Copy link
Member

daftspunk commented Dec 21, 2019

The markup provided by components is generally intended as a usage example for the Component.

https://octobercms.com/docs/cms/components#customizing-default-markup

Realistically if this is a problem for you, you can create a boilerplate theme with the translations in it and reuse that across all your projects

@daftspunk daftspunk closed this Dec 21, 2019
@inalto
Copy link

inalto commented Jul 25, 2020

Hello,
I'd like to try to look at this from a different perspective.
I think having pretranslated basic strings for the components is a good idea.
In my case I have multiple installations in multiple languages that are updated by automatic scripts.
For educational purposes you can maybe put a comment next to the original language content.
Moving the translations into the theme is a possible solution but in my opinion it is more efficient to have them in the plugin in case of multiple installations.
This way you can comfortably update multiple installations automatically without having to take into account different translations between themes on a case by case basis.

Of course for those who manage a single project this makes no sense. :)
Thank you for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide frontend translations ?

3 participants