make info boxes for posts translatable

[andibraeu]

By default there was a line "Posted in on <Month day, Year>" for every language.

This PR enables users to use the translation plugin to translate these strings.

[bennothommo]

@andibraeu Would it be better to use the language strings directly in the component partial, instead of loading them up with the model? You can see an example here: rainlab/user-plugin#402 - which is a similar change to the one you are proposing, but for the User plugin.

[andibraeu]

thanks for your feedback.

Unfortunately I didn't get it to work with default values then.

rainlab.blog::lang.post.posted_on_prefix will be shown instead of a default value.

[LukeTowers]

@andibraeu why do you need default values? What is being passed is a backend language string, so use the filter that's meant to handle those (| trans, not | _). I.e. {{ 'rainlab.blog::lang.post.posted_on_prefix' | trans }}

[andibraeu]

thanks for your help, I'm new to twig and octobercms :)

I've made the changes

[andibraeu]

any news on that?

[bennothommo]

@andibraeu Would you mind testing my changes and let me know if that works for you? Also, feel free to adjust the lang file if necessary - wasn't sure if that's the correct syntax.

@LukeTowers let me know if my changes were what you were after.

[LukeTowers]

@bennothommo that looks good to me but can we have spaces around the Twig filter bar? i.e. val | filter instead of just val|filter? In my opinion that makes it much easier to read.

[andibraeu]

That change means, that we'll see "in uncategorized" for every post that's not in a catergory?

[LukeTowers]

Good catch @andibraeu. @bennothommo I think we should remove the uncategorized fallback

[LukeTowers]

Although not sure how to best handle that

[bennothommo]

@LukeTowers I did consider that as well, but I didn't think any of the options for that were graceful if we were attempting to simplify the wording down to one language string, ie.

• Have a second language string if no categories are provided.
• Adding an "in " prefix to the categoryLinks variable above if categories are present, and remove it from the language string.

I felt having it show up as Uncategorized fits the spirit of the plugin, given that Blog posts are categorised, and matches similar functionality to Wordpress. If people didn't like it, they always had the option of overwriting the partial.

[LukeTowers]

@bennothommo I agree with you in principle, however this is a change to the default partial that people are using on their sites out in the wild. You wouldn't expect random strings to start appearing on your frontend after an update so we can't really make that sort of change here.

[bennothommo]

@LukeTowers Fair point - I've added a second language string when no categories are present, so the difference in languages can be done purely through the language files. Also, added spaces around the Twig filters.

[andibraeu]

are there any news on that?

[bennothommo]

@andibraeu The changes are awaiting confirmation that they work before being merged. Have you had a chance to test them?

[andibraeu]

yes, I tested it, and I use it. You can see the results here: https://weimarnetz.de/blog

[bennothommo]

Thanks @andibraeu!