Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please can you re-release dropping node 14 support as a breaking change? #1300

Closed
3 tasks done
mattlewis92 opened this issue May 9, 2023 · 5 comments
Closed
3 tasks done
Labels
Milestone

Comments

@mattlewis92
Copy link

  • I have searched for similar issues
  • I am using the latest version of npm-check-updates
  • I am using node >= 14.14

Steps to Reproduce

N/A

Current Behavior

Hey there! 👋 Installing the latest version of this package (>= 16.10.9) with engines-strict=true in a CI pipeline running node 14 fails:
CleanShot 2023-05-09 at 13 17 44

We're still in the process of upgrading all our pipelines to node 16 but any that have not yet been upgraded are failing due to node 14 support getting dropped in this package and this is causing us quite a bit of pain to manually have to go in and fix everything.

Expected Behavior

When a node major support is dropped in a library it should be marked as a breaking change to prevent these kinds of problems (we currently have "npm-check-updates": "^16", in our package.json). If you could revert this commit and instead re-release it as a breaking change in v17 that would help us out tremendously so we can avoid a tonne of manual work to fix all our failing pipelines. Thank you!

@raineorshine
Copy link
Owner

Thanks for bringing this to my attention. This was not intentional. I have reverted the commit and published to v16.10.11. If the engine gets bumped, it will be released as a major version upgrade.

@raineorshine
Copy link
Owner

I'm investigating the test failures.

@mattlewis92
Copy link
Author

Thanks for bringing this to my attention. This was not intentional. I have reverted the commit and published to v16.10.11. If the engine gets bumped, it will be released as a major version upgrade.

Thank you so much, it's very much appreciated! 🙌

@ekwoka
Copy link

ekwoka commented Jul 11, 2023

Node 14 isn't supported by Node.

@raineorshine
Copy link
Owner

Closing as there is no work left to do on this issue.

See https://github.com/raineorshine/npm-check-updates/milestone/3 for issues remaining for the next major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants