fix: <ConnectButton.Custom /> not displaying balance
#1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
magiziz
commented
Feb 8, 2024
| }) => { | ||
| const ready = mounted && connectionStatus !== 'loading'; | ||
| const unsupportedChain = chain?.unsupported ?? false; | ||
| ready && ( |
There was a problem hiding this comment.
Only thing i did here was ready && ... didn't touch any other elements of the component
magiziz
changed the title
<ConnectButton.Custom /> not displaying balance
1 task
DanielSinclair
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
<ConnectButton.Custom />doesn't give balance back due to ourshowBalancecontext API blocking it. It's now forced to show balance.<ConnectButton />we wait until context API gets updated and then decide whether we show the balance or not. This way we don't show balance right away, but rather wait until we get some value from the context API.What to test
<ConnectButton />and<ConnectButton.Custom />at the same time since it'll force call rpc balance if you use the custom one.<ConnectButton.Custom />it should show balance no matter what. Look at network tab and see that the rpc is being called.<ConnectButton />it should work as is right now with different responsive screen sizes.We don't want to expose another prop to our
<ConnectButton.Custom />so we'll try to use context API as much as possible here 👍