refactor: introduce market domain for price-change display - #7813
Open
olerass wants to merge 1 commit into
Open
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The price-change display helpers (percent formatting with directional arrows, the gain/loss color mapping) currently live under
framework/, which is reserved for code with no domain knowledge. Up-arrow-means-gain and green-means-up are market display conventions, not app-agnostic infrastructure. The current placement violates upcoming dependency rules (framework cannot depend on anything outside it, except npm libs).This change introduces a
features/marketdomain and moves them there, layered from the start (ui/only; no data or core exists yet) with the React hook split from the pure color helpers. Consumers in discover and perps are rewired.Scope note: the app currently renders price trends several inconsistent ways (SF-symbol arrows here, an up-arrow/hyphen pair in king-of-the-hill, sign-driven arrow rotation in the legacy chart label). This PR only relocates the most-shared variant; aligning on one model is separate design work, which now has an owning domain to consolidate into.
Ref APP-4084.