Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases #93

Open
gurdeep330 opened this issue Oct 13, 2022 · 2 comments
Open

Test cases #93

gurdeep330 opened this issue Oct 13, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@gurdeep330
Copy link
Member

Write tests to check with different inputs

@gurdeep330 gurdeep330 added the enhancement New feature or request label Oct 13, 2022
@gurdeep330 gurdeep330 self-assigned this Oct 13, 2022
gurdeep330 pushed a commit that referenced this issue Oct 13, 2022
gurdeep330 pushed a commit that referenced this issue Oct 13, 2022
gurdeep330 pushed a commit that referenced this issue Oct 14, 2022
@gurdeep330
Copy link
Member Author

Hi @raimondifranc @nataliarosa9 @maticmarin ,

As we had discussed several weeks ago (Rob's email), I added (to begin with) some cases that will be automatically tested by GitHub (check folder) using the package pytest
As of now, every time we push any change to GitHub, it will automatically make the following checks:

  1. Input: TP53 Expected: NOT OK (TP53 is not a GPCR)
  2. Input: P32249 Expected: OK (this is a GPCR)
  3. Input MC1R/M294L Expected: OK (this is a GPCR)
  4. Input P046 Expected: NOT OK (Invalid UniProt Acc)
  5. Input AGRV1_HUMAN Expected: NOT OK (though it is a GPCR but the len > 1024)

Since these tests involve running precogx (command line) via GitHub actions, it will also throw an error if the tests fail for any other reasons (eg: UniProt updates its API and thus precogx script fails - like what happened when Rob wrote us).

I will add more tests in the next weeks (eg: check if the position of the variant is incorrect). Hopefully, with this, we will avoid running into situations where precogx fails because of some stupid backend errors.

Let me know if you have more tests to suggest.

nice weekend,
gd

PS: this is still in branch beta. Will merge with main later (after you also have reviewed the frontend changes)

@raimondifranc
Copy link

raimondifranc commented Oct 17, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants