-
Notifications
You must be signed in to change notification settings - Fork 135
Skip 2FA prompt for token-based auth #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,4 +5,5 @@ pub mod progress; | |
| pub mod prompt; | ||
| pub mod retry; | ||
| pub mod time; | ||
| pub mod two_factor; | ||
| pub mod watcher; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| use anyhow::{Result, bail}; | ||
|
|
||
| use crate::{ | ||
| Configs, | ||
| client::post_graphql, | ||
| errors::RailwayError, | ||
| gql::{mutations, queries}, | ||
| util::prompt::prompt_text, | ||
| }; | ||
|
|
||
| /// Validates 2FA if enabled for the current user. | ||
| /// Skips check entirely for token-based auth (API tokens bypass 2FA on the backend). | ||
| /// For session-based auth, prompts for 2FA code if enabled, or uses provided code. | ||
| pub async fn validate_two_factor_if_enabled( | ||
| client: &reqwest::Client, | ||
| configs: &Configs, | ||
| is_terminal: bool, | ||
| two_factor_code: Option<String>, | ||
| ) -> Result<()> { | ||
| // Skip 2FA check for token-based auth (API tokens bypass 2FA on the backend) | ||
| if Configs::is_using_token_auth() { | ||
| return Ok(()); | ||
| } | ||
|
|
||
| let is_two_factor_enabled = { | ||
| let vars = queries::two_factor_info::Variables {}; | ||
| let info = post_graphql::<queries::TwoFactorInfo, _>(client, configs.get_backboard(), vars) | ||
| .await? | ||
| .two_factor_info; | ||
| info.is_verified | ||
| }; | ||
|
|
||
| if is_two_factor_enabled { | ||
| let token = if let Some(code) = two_factor_code { | ||
| code | ||
| } else if is_terminal { | ||
| prompt_text("Enter your 2FA code")? | ||
| } else { | ||
| bail!( | ||
| "2FA is enabled and requires interactive mode. Use --2fa-code <CODE> or an API token for non-interactive operations." | ||
| ); | ||
| }; | ||
|
|
||
| let vars = mutations::validate_two_factor::Variables { token }; | ||
|
|
||
| let valid = | ||
| post_graphql::<mutations::ValidateTwoFactor, _>(client, configs.get_backboard(), vars) | ||
| .await? | ||
| .two_factor_info_validate; | ||
|
|
||
| if !valid { | ||
| return Err(RailwayError::InvalidTwoFactorCode.into()); | ||
| } | ||
| } | ||
|
|
||
| Ok(()) | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.