Skip to content

Add rails v7.1 docs / Add rails v7.0 subdirectory / Enhance list of Rails versions in navigation menu #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 12, 2023

Conversation

toshimaru
Copy link
Member

@toshimaru toshimaru commented Oct 10, 2023

close #124

Changes

  • Add rails v7.1.0 documentation
  • Update BUNDLE_WITHOUT
  • Add Rails v7.0 documentation with 7.0 directory
  • Enhance list of Rails versions

BUNDLE_ONLY can't used

BUNDLE_ONLY=doc doesn't work because generating the documentation requires additional gems (e.g. rails, rake...) in addition to the gems grouped under doc.

@toshimaru toshimaru force-pushed the add-rails7.1-part2 branch 2 times, most recently from a72cffc to df31240 Compare October 11, 2023 02:09
Do not install unnecessary gems

[`BUNDLE_ONLY` can't used]
`BUNDLE_ONLY=doc` doesn't work since the doc generation
requires additional gems (e.g. rails, rake...) along with doc gems
After installing Nokogiri v1.14, the installation of Nokogiri v1.11 fails.

```
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

current directory:
/opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/nokogiri-1.11.3/ext/nokogiri
/opt/hostedtoolcache/Ruby/2.7.8/x64/bin/ruby -I
/opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/2.7.0 -r
./siteconf20231010-5219-1a02hdd.rb extconf.rb
checking for whether -g is accepted as CFLAGS... yes
checking for whether -Winline is accepted as CFLAGS... yes
checking for whether -Wmissing-noreturn is accepted as CFLAGS... yes
Building nokogiri using packaged libraries.
Static linking is enabled.
Cross build is disabled.
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.
```
Therefore, install nokogiri from old versions by using `reverse_each`.
@toshimaru toshimaru changed the title Add rails v7.1 docs Add rails v7.1 docs / Add rails v7.0 subdirectory Oct 11, 2023
@toshimaru toshimaru changed the title Add rails v7.1 docs / Add rails v7.0 subdirectory Add rails v7.1 docs / Add rails v7.0 subdirectory / Enhance list of Rails versions in navigation menu Oct 12, 2023
@toshimaru toshimaru marked this pull request as ready for review October 12, 2023 13:17
@toshimaru toshimaru merged commit 3d1944e into railsdoc:main Oct 12, 2023
@toshimaru toshimaru deleted the add-rails7.1-part2 branch October 13, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant