Skip to content

zh-tw subdomain #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2014
Merged

Conversation

yorkxin
Copy link
Contributor

@yorkxin yorkxin commented Jun 25, 2014

Hi,

We recently run many workshops using your RailsBridge document. It's pretty good for newbies. Thanks for your great work!

However the URL of document is hard to remember. Currently it's http://railsbridge-docs-zh-tw.herokuapp.com/ with a short cut URL http://bit.ly/railsbridge-tw

It would be great if the URL becomes http://zh-tw.railsbridge.org so it is easier to remember and people who read Chinese can link to our version from your website.

By merging this pull request, the nav bar will be look like this, which you can see in our current website:

screen shot 2014-06-25 at 09 51 42

However, in addition to merging PR, to serve an aliased domain name, there are some DNS setups that should be configured (as mentioned in #294). Would you do this for us?

And by the way, I see in app.js/locale there is a comment saying that locale-by-subdomain supports only 2-digits language name. We're using 5 digits (zh-tw), but there is no locale-switching issue on our Heroku deployment, because we've forcibly set locale to zh-tw when running up the server. There might be another issues in the future but not urgent.

Thanks again!

@tjgrathwell
Copy link
Member

I can merge this code in, but I'm not really sure what's going on with the DNS stuff. @alexch does it make sense to do the same thing that's currently happening for es.railsbridge.org? Who can update that? How is that set up?

@yorkxin
Copy link
Contributor Author

yorkxin commented Jun 29, 2014

I've setup custom domain on my heroku app. All you need to do is adding this DNS record to railsbridge.org:

CNAME   zh-tw   railsbridge-docs-zh-tw.herokuapp.com.

After that, zh-tw.railsbridge.org would be pointed to our Chinese translation site.

@rachelmyers
Copy link
Member

Friendly nudge to @alexch (or others?) on the DNS change. It would be awesome to get this merged! 🐎

@lilliealbert
Copy link
Member

It's probably past time to move RailsBridge's DNS onto a shared account, right? Only @alexch having access to it is a worryingly low bus number.

On Jul 12, 2014, at 12:04 AM, Rachel Myers notifications@github.com wrote:

Friendly nudge to @alexch (or others?) on the DNS change. It would be awesome to get this merged!


Reply to this email directly or view it on GitHub.

@alexch
Copy link
Contributor

alexch commented Jul 14, 2014

On Sat, Jul 12, 2014 at 8:16 AM, Lillie Chilen notifications@github.com
wrote:

It's probably past time to move RailsBridge's DNS onto a shared account,
right? Only @alexch having access to it is a worryingly low bus number.

It was moved to a shared DNSimple account (username admin@bridgefoundry.org)
a while ago. I know @ultrasaurus has access to it but I don't know who else
does. Is there a shared passwords database somewhere I can go add the info
to?

In the meantime, I'll fix this issue now. Rachel, thanks for the ping.

We're using 5 digits (zh-tw), but there is no locale-switching issue on
our Heroku
deployment, because we've forcibly set locale to zh-tw when running up
the server.

That's important. We should merge all these language forks into the main
repo soon, and when that happens we need to make 5-char locales work.

  • A

@alexch
Copy link
Contributor

alexch commented Jul 14, 2014

worryingly low bus number

By the way, my friend/client @ajrossman recently renamed this "island
number" since it's much more nice to imagine someone retiring to a
tropical island than getting hit by a bus :-)

  • A

@alexch
Copy link
Contributor

alexch commented Jul 14, 2014

DNS mapped. With DNSimple, CNAME doesn't seem to work; you have to use their special ALIAS type.

@@ -13,7 +13,7 @@ def self.css_path

def initialize *args
super
@locales = ["us", "es"]
@locales = ["us", "es", "zh-tw"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if this list used ::Installfest::AVAILABLE_LOCALES instead.

(Also if Installfest were renamed RailsbridgeDocs :-))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we're going to support per-curriculum localization, right? That'll be great too!

alexch added a commit that referenced this pull request Jul 14, 2014
@alexch alexch merged commit 72b2f7a into railsbridge:master Jul 14, 2014
@yorkxin
Copy link
Contributor Author

yorkxin commented Jul 14, 2014

Thank you so much for merging this PR!

@wildjcrt
Copy link

Thanks all folks! <3 <3 <3

@ultrasaurus
Copy link
Member

Greg Nokes volunteered to manage DNS. Alex and I also have access. This went by on the email list a while back. Any thoughts on a good place to keep this info so folks can refer to it?

On Jul 14, 2014, at 7:27 AM, Alex Chaffee notifications@github.com wrote:

On Sat, Jul 12, 2014 at 8:16 AM, Lillie Chilen notifications@github.com
wrote:

It's probably past time to move RailsBridge's DNS onto a shared account,
right? Only @alexch having access to it is a worryingly low bus number.

It was moved to a shared DNSimple account (username admin@bridgefoundry.org)
a while ago. I know @ultrasaurus has access to it but I don't know who else
does. Is there a shared passwords database somewhere I can go add the info
to?

In the meantime, I'll fix this issue now. Rachel, thanks for the ping.

We're using 5 digits (zh-tw), but there is no locale-switching issue on
our Heroku
deployment, because we've forcibly set locale to zh-tw when running up
the server.

That's important. We should merge all these language forks into the main
repo soon, and when that happens we need to make 5-char locales work.

  • A

    Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants