-
Notifications
You must be signed in to change notification settings - Fork 451
zh-tw subdomain #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zh-tw subdomain #370
Conversation
I can merge this code in, but I'm not really sure what's going on with the DNS stuff. @alexch does it make sense to do the same thing that's currently happening for es.railsbridge.org? Who can update that? How is that set up? |
I've setup custom domain on my heroku app. All you need to do is adding this DNS record to
After that, zh-tw.railsbridge.org would be pointed to our Chinese translation site. |
Friendly nudge to @alexch (or others?) on the DNS change. It would be awesome to get this merged! 🐎 |
It's probably past time to move RailsBridge's DNS onto a shared account, right? Only @alexch having access to it is a worryingly low bus number.
|
On Sat, Jul 12, 2014 at 8:16 AM, Lillie Chilen notifications@github.com
It was moved to a shared DNSimple account (username admin@bridgefoundry.org) In the meantime, I'll fix this issue now. Rachel, thanks for the ping.
That's important. We should merge all these language forks into the main
|
By the way, my friend/client @ajrossman recently renamed this "island
|
DNS mapped. With DNSimple, CNAME doesn't seem to work; you have to use their special |
@@ -13,7 +13,7 @@ def self.css_path | |||
|
|||
def initialize *args | |||
super | |||
@locales = ["us", "es"] | |||
@locales = ["us", "es", "zh-tw"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice if this list used ::Installfest::AVAILABLE_LOCALES
instead.
(Also if Installfest
were renamed RailsbridgeDocs
:-))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we're going to support per-curriculum localization, right? That'll be great too!
Thank you so much for merging this PR! |
Thanks all folks! <3 <3 <3 |
Greg Nokes volunteered to manage DNS. Alex and I also have access. This went by on the email list a while back. Any thoughts on a good place to keep this info so folks can refer to it? On Jul 14, 2014, at 7:27 AM, Alex Chaffee notifications@github.com wrote:
|
Hi,
We recently run many workshops using your RailsBridge document. It's pretty good for newbies. Thanks for your great work!
However the URL of document is hard to remember. Currently it's http://railsbridge-docs-zh-tw.herokuapp.com/ with a short cut URL http://bit.ly/railsbridge-tw
It would be great if the URL becomes http://zh-tw.railsbridge.org so it is easier to remember and people who read Chinese can link to our version from your website.
By merging this pull request, the nav bar will be look like this, which you can see in our current website:
However, in addition to merging PR, to serve an aliased domain name, there are some DNS setups that should be configured (as mentioned in #294). Would you do this for us?
And by the way, I see in
app.js/locale
there is a comment saying that locale-by-subdomain supports only 2-digits language name. We're using 5 digits (zh-tw
), but there is no locale-switching issue on our Heroku deployment, because we've forcibly set locale to zh-tw when running up the server. There might be another issues in the future but not urgent.Thanks again!