-
Notifications
You must be signed in to change notification settings - Fork 9
Update the README #12
Conversation
e537dc3
to
af2e18f
Compare
@@ -22,7 +22,11 @@ The Vagrantfile will allow you to rebuild the RailsBridge VM from scratch. Run: | |||
|
|||
rake up | |||
|
|||
This just runs `vagrant up`. The base box will be downloaded directly from Ubuntu if it hasn't already been added. Building Ruby takes a while, so get some coffee. | |||
This just runs `vagrant up`. Don't worry about the red text - unless the process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least, I assume I shouldn't worry about the red text!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the red text?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try cloning this repo then running vagrant up
. There's red text periodically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything that the install process prints to stderr (as opposed to stdout) gets colored red. (Good thing regular terminals don't do this, heh...)
The note here is good but I'm trying to avoid hard line breaks in this file; can you re-wrap? (the graf in 25-27 should be on one line)
af2e18f
to
955cbbe
Compare
This is a continuation of https://github.com/railsbridge-boston/docs/issues/25. |
@decklin Assuming this is merged, can you take care of creating the gold master and uploading to S3? |
955cbbe
to
88adebc
Compare
This looks fine to me. Any thoughts, @decklin? |
@@ -48,6 +52,11 @@ Files are copied into the VM from these directories: | |||
* `etcfiles` to `/etc` (as root) | |||
* `dotfiles` to `/home/vagrant` (as the user) | |||
|
|||
To apply your changes to the local Vagrant box that you booted with `vagrant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, vagrant up
should re-run the provison, which should be idempotent, but will definitely re-run more than it strictly needs to. I'll have to think about this.
Thanks - I will take a look at this tomorrow! |
[push] | ||
# This makes it push master when someone types `git push heroku` | ||
# instead of `git push heroku master` | ||
default = current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this should be "simple" (see http://git-scm.com/docs/git-config), that's the new default.
Trusty is still on git 1.9.1; the comment should say that it's to match the default behavior of git 2.0 (which is what students will get if they later install it directly/with homebrew/from backports).
Made some line comments - could you split this up into the doc updates and the git stuff? (2 PRs) |
88adebc
to
92db895
Compare
I force-pushed this so it's just the README updates. I'll leave the dotfiles and git changes to #16. |
@@ -48,6 +50,10 @@ Files are copied into the VM from these directories: | |||
* `etcfiles` to `/etc` (as root) | |||
* `dotfiles` to `/home/vagrant` (as the user) | |||
|
|||
To apply your changes to the local Vagrant box that you booted with `vagrant up`, run `vagrant destroy` and then `vagrant up` again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@decklin's previous comment:
Well,
vagrant up
should re-run the provison, which should be idempotent, but will definitely re-run more than it strictly needs to. I'll have to think about this.
Added one commit, merge if it looks good to you. |
I like that we recommend |
ac4545b
to
1f3d373
Compare
Update the docs