Make connect_timeout work with DNS resolution#3337
Open
haukot wants to merge 2 commits intorails:masterfrom
Open
Make connect_timeout work with DNS resolution#3337haukot wants to merge 2 commits intorails:masterfrom
haukot wants to merge 2 commits intorails:masterfrom
Conversation
Before it could timeout connection process, but still wait for DNS resolution for long time. It's possible to interrupt addrinfo in ruby 3+
d636073 to
2812c8f
Compare
haukot
commented
Jul 16, 2024
| require "rails" | ||
| require "rails/test_help" | ||
| require "byebug" | ||
| require "ostruct" |
Author
There was a problem hiding this comment.
Without this tests were failing with
Error:
CompilerTest#test_freshness_on_compile_success:
NameError: uninitialized constant CompilerTest::OpenStruct
e.g. on https://github.com/rails/webpacker/actions/runs/9956692322/job/27507151674#step:4:83
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before it could timeout the connection process, but it still waits for DNS resolution, in some systems for a long time(e.g. on Alpine I see that connection timeouts only after 5 seconds).
It's possible to interrupt the name resolution in ruby 3.3+, tested on 3.3.4 (related issue https://bugs.ruby-lang.org/issues/19965)