Skip to content

[5.x] CI fixes #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 17, 2021
Merged

[5.x] CI fixes #3106

merged 3 commits into from
Aug 17, 2021

Conversation

pedrofurtado
Copy link
Member

@pedrofurtado pedrofurtado commented Aug 11, 2021 •
edited
Loading

@pedrofurtado pedrofurtado changed the base branch from master to 5-x-stable August 11, 2021 20:16
@pedrofurtado pedrofurtado mentioned this pull request Aug 11, 2021
Merged
@olleolleolle
Copy link
Contributor

olleolleolle commented Aug 12, 2021 •
edited
Loading

Here is a description of what this PR does:

  • c7007f3 Gemfile for Rails edge: Use the main branch as its default Git branch
  • 4b1128d CI matrix: Rails edge should not be tested on Ruby versions < 2.7, so those two matrix elements are removed
  • a2b5e90 helper_test.rb: Expectations more robust to differences in emitted markup.

olleolleolle
olleolleolle approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find these changes solid, and I have described them above.

@olleolleolle
Copy link
Contributor

👋 @guilleiguaran Eh, hi! I hope that this PR could be merged, it's pretty cool.

@dhh dhh merged commit bf525f3 into rails:5-x-stable Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@olleolleolle olleolleolle olleolleolle approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pedrofurtado @olleolleolle @dhh