Add disable_required_check! and make disable the check in help #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sferik
approved these changes
Feb 18, 2017
In Thor 0.19.2 it was added a new class method disable_class_options. It was added to disable the check for required options in the help command. This new method disabled the option parser for help, so it is not possible to pass option to that command anymore. That change introduced a regression and it is fixing the problem at the wrong level. What we want is to disable the required check not the option parsing. So, we reverted the disable_class_options change and added a new method disable_required_check! to disable the required check in the commands we want. Theoretically this is a breaking change but the disable_class_options introduction was also a breaking change so it is better to revert it and fix the problem at the correct place. Related with #462 and #363.
rafaelfranca
force-pushed
the
fix-disable_class_options
branch
from
1a3f665 to
35ab20d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Thor 0.19.2 it was added a new class method
disable_class_options.It was added to disable the check for required options in the help command. This new method disabled the option parser for help, so it is not possible to pass option to that command anymore.
That change introduced a regression and it is fixing the problem at the wrong level. What we want is to disable the required check not the option parsing.
So, we reverted the
disable_class_optionschange and added a new methoddisable_required_check!to disable the required check in the commands we want.Theoretically this is a breaking change but the
disable_class_optionsintroduction was also a breaking change so it is better to revert it and fix the problem at the correct place.Related with #462 and #363.
See rubygems/bundler#5221