fix subcommand method help

[akm]

If these classes are defined,

module SubcommandTest1
  class Child1 < Thor
    desc "foo NAME", "Fooo"
    def foo(name)
      puts "#{name} was given"
    end
  end

  class Parent < Thor
    desc "child1", "child1 description"
    subcommand "child1", Child1
  end
end

SubcommandTest1::Parent.start(%w[child1 foo]) puts messages to $stderr

on current master

ERROR: "thor foo" was called with no arguments
Usage: "thor subcommand_test1:child1:foo NAME"

on this pull request branch

ERROR: "thor child1 foo" was called with no arguments
Usage: "thor child1 foo NAME"

[astratto]

@akm I have the very same issue and it's fixed by this patch

👍

[Linuus]

@sferik Would it be possible to get this merged?

[sferik]

Why should the behavior change?

[akm]

Because ExcitingPluginCLI is registered with subcommand_name "exciting" by the following code:

BoringVendorProvidedCLI.register(
  ExcitingPluginCLI,
  "exciting",
  "do exciting things",
  "Various non-boring actions")

https://github.com/groovenauts/thor/blob/d31a6ef82cb155ef11f6326ac555070fd727df5e/spec/register_spec.rb#L99-L103

[akm]

fix conflict

[doudou]

What would be the downside of simply setting the namespace on the class to the subcommand name by default ?

[akm]

@doudou Could you explain what you mean?

[doudou]

The workaround I found (and that, it seems, is generally used) is to explicitely set the subcommand's namespace, as

class MainTest < Thor
  namespace 'test'
end

I was wondering what are the upside/downside of your solution vs. doing

subcommand_class.namespace subcommand

in #subcommand

[akm]

@doudou thank you for your comment.

Did you mean like this?

#!/usr/bin/env ruby

require 'thor'
require 'thor/version'
puts "Thor::VERSION: #{Thor::VERSION}"

module SubcommandTest1
  class Child1 < Thor
    namespace "child1"

    desc "foo NAME", "Fooo"
    def foo(name)
      puts "#{name} was given"
    end
  end

  class Parent < Thor
    desc "child1", "child1 description"
    subcommand "child1", Child1
  end
end

SubcommandTest1::Parent.start(ARGV)

Save this file as thortest and chmod 755 thortest .

But I think it behaves a little strange:

$ ./thortest             
Thor::VERSION: 0.19.1
Commands:
  thortest child1          # child1 description
  thortest help [COMMAND]  # Describe available commands or one specific command

$ ./thortest child1      
Thor::VERSION: 0.19.1
Commands:
  thortest child1 foo NAME        # Fooo
  thortest child1 help [COMMAND]  # Describe subcommands or one specific subc...

$ ./thortest child1 foo
Thor::VERSION: 0.19.1
ERROR: "thortest foo" was called with no arguments
Usage: "thortest foo NAME"

The namespace "child1" has gone from the last message.

What should I do to see the message like this?

$ ./thortest child1 foo
ERROR: "thortest child1 foo" was called with no arguments
Usage: "thortest child1 foo NAME"

[doudou]

I guess one would have to fix Base#handle_argument_error to add namespace support

[doudou]

@akm: can you comment on closing this ? Did you push another fix for the same issue ?

[akm]

@doudou Sorry. I've just mistaken, so re-opened this PR.

[sferik]

@akm Thank you for this patch!

[akm]

@sferik Thank you for merging this!