Merge pull request #718 from bpo/fix-verbose-warnings

🌈 Fix another warning about $thor_runner

lib/thor.rb

@@ -2,6 +2,7 @@
 require_relative "thor/base"
 
 class Thor
+  $thor_runner ||= false
   class << self
     # Allows for custom "Command" package naming.
     #
@@ -398,7 +399,6 @@ def dispatch(meth, given_args, given_opts, config) #:nodoc: # rubocop:disable Me
     # the namespace should be displayed as arguments.
     #
     def banner(command, namespace = nil, subcommand = false)
-      $thor_runner ||= false
       command.formatted_usage(self, $thor_runner, subcommand).split("\n").map do |formatted_usage|
         "#{basename} #{formatted_usage}"
       end.join("\n")

spec/fixtures/verbose.thor

@@ -5,6 +5,9 @@ $VERBOSE = true
 require 'thor'
 
 class Test < Thor
+  def self.exit_on_failure?
+    true
+  end
 end
 
 Test.start(ARGV)

spec/no_warnings_spec.rb

@@ -7,4 +7,10 @@
 
     expect(err).to be_empty
   end
+
+  it "prints no warnings even when erroring" do
+    root = File.expand_path("..", __dir__)
+    _, err, = Open3.capture3("ruby -I #{root}/lib #{root}/spec/fixtures/verbose.thor noop")
+    expect(err).to_not match(/warning:/)
+  end
 end