Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use character for #delete_prefix instead of RegEx #685

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Use character for #delete_prefix instead of RegEx #685

merged 1 commit into from
Jun 5, 2020

Conversation

matteeyah
Copy link
Contributor

@matteeyah matteeyah commented Jun 5, 2020 •
edited
Loading

This will make the pipeline green again so 4.0.2 can get released.

53efbb8 changed a call from sub to delete_prefix but left the same sub parameters instead of switching to just using a single character.

@matteeyah
Copy link
Contributor Author

@rafaelfranca Mind taking a quick look at this?

@matteeyah
Copy link
Contributor Author

I don't think this warrants a changelog - there's no user preceiveable change here, it's just a spec fix.

@matteeyah matteeyah mentioned this pull request Jun 5, 2020
Closed
@rafaelfranca rafaelfranca merged commit 8fc492a into rails:master Jun 5, 2020
This was referenced Mar 15, 2021
Open
Open
Open
Open
Open
Open
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteeyah @rafaelfranca