Skip to content

CI: Use ruby 2.4.9, 2.5.7, 2.6.5 and rails 6.0.0 #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mikong
Copy link

@mikong mikong commented Oct 24, 2019

Bump the Ruby versions used by Travis CI. Also update from Rails 6.0.0.rc1 to 6.0.0.

@mikong
Copy link
Author

mikong commented Oct 24, 2019

The build is failing for Ruby 2.4.9 because it's unable to install rails. sprockets 4.0.0 now requires Ruby version >= 2.5.0. Should we drop support for Ruby 2.4.x?

Or use sprockets 3.7.2 instead of 4.0.0?

@rafaelfranca
Copy link
Member

Lets use sprockets 3.7.

@mikong
Copy link
Author

mikong commented Oct 29, 2019

Alright. I updated my PR to install sprockets 3.7 under before_install. However, that means it's installed for all jobs. Please let me know if sprockets 3.7 should only be installed for Ruby 2.4. I'm not sure what the best way to do that though.

@byroot
Copy link
Member

byroot commented Nov 23, 2021

Closing as outdated. Thanks for the patch though.

@byroot byroot closed this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants