Adds batch processing support #590
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds on some work that I did for Sidekiq actually. I had to put a database in front of sidekiq to make it work like I wanted and to ensure that no duplicates are processed while some stuff needs to happen at the end.
|
Hey @mhenrixon, thanks for this! I haven't looked at it yet, but there's a previous PR for batch support: #142 and a discussion there. It's work in progress as well, but maybe the discussion there is relevant for this, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on some work that I did for Sidekiq.
I had to put a database in front of Sidekiq to make it work as I wanted and to ensure that no duplicates are processed, while some tasks need to occur at the end.
There are several factors to consider, including the tracking of pending jobs. This might be better as a simple query, depending on how fast the jobs are processed; it could cause side effects with concurrent increments.
This is intended to initiate a discussion. There are other ways of handling this, but none that I like. This is the only approach that I can think of that doesn't have too many negatives.
The only negative is the database changes.