Skip to content

Add capability to discard duplicate jobs with concurrency configuration #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests which expect raising enqueue errors
  • Loading branch information
joelzwarrington committed Jun 23, 2025
commit af166502b84dfabbccabc8612273bfdbfe6b6eb8
8 changes: 5 additions & 3 deletions test/models/solid_queue/job_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -333,13 +333,15 @@ class DiscardedNonOverlappingGroupedJob2 < NonOverlappingJob
test "raise EnqueueError when there's an ActiveRecordError" do
SolidQueue::Job.stubs(:create!).raises(ActiveRecord::Deadlocked)

active_job = AddToBufferJob.new(1).set(priority: 8, queue: "test")
assert_raises SolidQueue::Job::EnqueueError do
active_job = AddToBufferJob.new(1).set(priority: 8, queue: "test")
SolidQueue::Job.enqueue(active_job)
end

assert_raises SolidQueue::Job::EnqueueError do
AddToBufferJob.perform_later(1)
# #perform_later doesn't raise ActiveJob::EnqueueError, and instead set's successfully_enqueued? to false
assert_not AddToBufferJob.perform_later(1) do |active_job|
assert_not active_job.successfully_enqueued?
assert_equal SolidQueue::Job::EnqueueError, active_job.enqueue_error.class
end
end

Expand Down
Loading