Attempt to clarify the note on postgres support #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npezza93
requested changes
Sep 17, 2024
README.md
Outdated
| > broadcasting large payloads, Solid Cable will work without a hitch. | ||
| > Solid Cable is tested to work with MySQL, SQLite, and PostgreSQL. | ||
| > | ||
| > Action Cable already has a [dedicated PostgreSQL adapter](https://github.com/rails/rails/blob/main/actioncable/lib/action_cable/subscription_adapter/postgresql.rb), |
There was a problem hiding this comment.
We should point to the Rails docs here instead of the code. https://guides.rubyonrails.org/action_cable_overview.html#postgresql-adapter
* On twitter, some folks (myself included) were confused about the note and thought it was implying some issue with using this gem with Postgres * This tries to emphasize first that all three are fully supported. Then it tries to specify a bit more clearly the distinction about the action cable built-in adapter vs solid cable * Also mentions potentially hitting issues with the payload size, or not wanting the `NOTIFY` command (which may be a problem for some folks using pgbouncer)
jpcamara
force-pushed
the
clarify-pg-support-docs
branch
from
1f49d9e
to
8cf63af
Compare
|
Good call @npezza93 - I just updated it to point at the rails docs instead |
npezza93
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On twitter, some folks (myself included) were confused about the note and thought it was implying some issue with using this gem with Postgres
This tries to emphasize first that all three are fully supported. Then it tries to specify a bit more clearly the distinction about the action cable built-in adapter vs solid cable
Also mentions potentially hitting issues with the payload size, or not wanting the
NOTIFYcommand (which may be a problem for some folks using pgbouncer)