Skip to content

[WIP] SassC support #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[WIP] SassC support #349

wants to merge 3 commits into from

Conversation

bolandrm
Copy link
Contributor

@bolandrm bolandrm commented Oct 6, 2015

This is very much WIP. Comments on the approach are welcome.

This depends on sprockets master (rails/sprockets#148)

@rails-bot
Copy link

r? @schneems

(@rails-bot has picked a reviewer for you, use r? to override)

@jeremy
Copy link
Member

jeremy commented Oct 6, 2015

👍

@guilleiguaran
Copy link
Member

@bolandrm I like the approach you're following in this.

We can add sassc gem commented on rails Gemfile and then the users can un-comment it to enable as alternative to default sass.

@guilleiguaran
Copy link
Member

I've added :sassc as compressor in rails/sprockets@dc78af8, so it can be switched in https://github.com/rails/sass-rails/blob/master/lib/sass/rails/railtie.rb#L80

@bolandrm
Copy link
Contributor Author

bolandrm commented Oct 6, 2015

Thanks @guilleiguaran. Testing this in a rails app. Working out some load path issues.

@camelmasa
Copy link

I hope it will be merge 👍 @bolandrm Will you continue this PR ❓ Or, we should use https://github.com/sass/sassc-rails

@Fudoshiki
Copy link
Contributor

sassc-rails works fine, but would like sassc in rails by default

@schneems
Copy link
Member

schneems commented May 9, 2017

I had some issues with windows and sassc. https://github.com/rails/sprockets/blob/master/test/shared_sass_tests.rb#L117 I tried to fix it, even bought a windows machine. I got hung up on the compilation toolchain and had to move to something else.

I'm interested in getting sassc support in sass-rails, would love to help move this along if possible.

@MikeRogers0
Copy link

I think sassc had a patch to fix the windows install problems ( sass/sassc#206 ) :D

I'm not sure the state of this branch, but I'd love to see this pushed out to all the gems still using sass :)

@guilleiguaran
Copy link
Member

See #424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants