Improve the performance of ActiveSupport::MessageEncryptor #43924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DNNX
reviewed
Dec 17, 2021
jcmfernandes
force-pushed
the
message-encryptor-perf-improvements
branch
from
c894a0f to
2fcacc4
Compare
We can avoid using String#split by calculating the indexes of the encrypted data, IV, and auth tag in the payload. This increases the resistance of the solution against ill-formed payloads that don't include the separator. This is a follow up to the work in PR rails#42919.
jcmfernandes
force-pushed
the
message-encryptor-perf-improvements
branch
from
58f68d6 to
0a0dc95
Compare
|
@rafaelfranca done! 🙌 |
jonathanhefner
added a commit
to jonathanhefner/rails
that referenced
this pull request
Jun 28, 2022
Follow-up to rails#43924. This commit refactors the logic around assembling and extracting the parts of a message (namely: the encrypted data, the IV, and the auth tag). It also provides a small but reproducible performance increase for a roundtrip. Benchmark: ```ruby require "benchmark/ips" require "active_support/message_encryptor" DATA = "x" * 100 ENCRYPTOR = ActiveSupport::MessageEncryptor.new(SecureRandom.random_bytes(32)) Benchmark.ips do |x| x.report("roundtrip") do ENCRYPTOR.decrypt_and_verify(ENCRYPTOR.encrypt_and_sign(DATA)) end end ``` Before: ``` Warming up -------------------------------------- roundtrip 1.342k i/100ms Calculating ------------------------------------- roundtrip 13.525k (± 1.5%) i/s - 68.442k in 5.061532s ``` After: ``` Warming up -------------------------------------- roundtrip 1.409k i/100ms Calculating ------------------------------------- roundtrip 14.125k (± 1.4%) i/s - 71.859k in 5.088419s ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following up on the work I did in #42919, this introduces the same logic to
ActiveSupport::MessageEncryptor.By calculating the position of the IV and auth tags, instead of using
String#split, we increase our resistance to invalid messages, those that don't feature the separator. The new code is not sensitive to the size of the input whenever it doesn't feature the separator.Besides the above, I'm making sure that the auth tag is 16 bytes, OpenSSL bindings' current default. A change to that default would break things for us, namely making it impossible to decrypt previously encrypted messages.
Other Information
Benchmarks
4 kB
Attempting to decrypt an invalid message (no separator).
Currently:
This PR:
A 1.37x speedup for
#decrypt_and_verify, and a 1.10x speedup for#encrypt_and_sign.Attempting to decrypt a valid message.
Currently:
This PR:
A 1.09x speedup for
#decrypt_and_verify, and a 1.07x speedup for#encrypt_and_sign.4 MB
Attempting to decrypt an invalid message (no separator).
Currently:
This PR:
A 326x speedup for
#decrypt_and_verify, and a 1.16x speedup for#encrypt_and_sign.Attempting to decrypt a valid message.
Currently:
This PR:
A 1.52x speedup for
#decrypt_and_verify, and a 1.12x speedup for#encrypt_and_sign.