Allow numbers in partial name for digesting #10377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems legit to me. I'm not sure why numbers aren't in there, is there a reason? |
ghost
assigned
| @@ -39,7 +39,7 @@ class ERBTracker | |||
| render\s* # render, followed by optional whitespace | |||
| \(? # start an optional parenthesis for the render call | |||
| (partial:|:partial\s+=>)?\s* # naming the partial, used with collection -- 1st capture | |||
| ([@a-z"'][@a-z_\/\."']+) # the template name itself -- 2nd capture | |||
| ([@a-z"'][@a-z0-9_\/\."']+) # the template name itself -- 2nd capture | |||
There was a problem hiding this comment.
Could you use \w here instead of a-z0-9_?
There was a problem hiding this comment.
@vanstee Good idea, I've made this improvement. 8627278
|
Could you add a CHANGELOG entry and squash your commits? Thanks |
Add failing test for template with number at the end Use \w for RENDER_DEPENDENCY regex Spacing Add CHANGELOG entry
|
@rafaelfranca 👍 Done. Any possibility of this making it into the next RC (or final release) of Rails 4.0? Thanks. |
rafaelfranca
added a commit
that referenced
this pull request
May 7, 2013
…mber Allow numbers in partial name for digesting
rafaelfranca
added a commit
that referenced
this pull request
May 7, 2013
…mber Allow numbers in partial name for digesting Conflicts: actionpack/CHANGELOG.md
rafaelfranca
added a commit
that referenced
this pull request
May 13, 2013
…mber Allow numbers in partial name for digesting Conflicts: actionpack/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regular expression would not match templates with numbers in the filename. For example:
Would result in (in the log):
Couldn't find template for digesting: shared/layout_.html... and no digest would be generated.