Don't envelop fragments in documents. #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents a body tag from being matched in an empty document. Closes #19
?
rafaelfranca
added a commit
that referenced
this pull request
Sep 29, 2014
Don't envelop fragments in documents.
kaspth
added a commit
to kaspth/rails
that referenced
this pull request
Sep 29, 2014
This is to match the changes in Rails Dom Testing rails/rails-dom-testing#20.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents a body tag from being matched in an empty document.
This changes the expectations for
document_root_elementso we need to update Rails as well. I'll submit a separate PR once this is merged.I'm pretty tired of issues like this because it's so hard to figure out if the node being searched from is included in the search or not. We're probably going to have more issues because of that behavior 😢
Closes #19