Skip to content

Add imagemagick package #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Add imagemagick package #214

merged 1 commit into from
Jan 12, 2024

Conversation

yahonda
Copy link
Member

@yahonda yahonda commented Jan 12, 2024

This commit addresses the "MiniMagick::Invalid: You must have ImageMagick or GraphicsMagick installed" error.

  • Steps to reproduce
vagrant ssh
git clone https://github.com/rails/rails
cd rails
bundle install
cd activestorage
bin/test test/models/representation_test.rb -n test_representing_an_image
  • This commit addresses the following error:
$ bin/test test/models/representation_test.rb -n test_representing_an_image
... snip ...
E

Error:
ActiveStorage::RepresentationTest#test_representing_an_image:
MiniMagick::Invalid: You must have ImageMagick or GraphicsMagick installed
    /var/lib/gems/3.1.0/gems/mini_magick-4.12.0/lib/mini_magick/image.rb:221:in `rescue in validate!'
    /var/lib/gems/3.1.0/gems/mini_magick-4.12.0/lib/mini_magick/image.rb:218:in `validate!'
    /var/lib/gems/3.1.0/gems/mini_magick-4.12.0/lib/mini_magick/image.rb:131:in `block in create'
    <internal:kernel>:90:in `tap'
    /var/lib/gems/3.1.0/gems/mini_magick-4.12.0/lib/mini_magick/image.rb:130:in `create'
    /var/lib/gems/3.1.0/gems/mini_magick-4.12.0/lib/mini_magick/image.rb:34:in `read'
    /var/lib/gems/3.1.0/gems/mini_magick-4.12.0/lib/mini_magick/image.rb:108:in `block in open'
    /var/lib/gems/3.1.0/gems/mini_magick-4.12.0/lib/mini_magick/image.rb:108:in `open'
    /var/lib/gems/3.1.0/gems/mini_magick-4.12.0/lib/mini_magick/image.rb:108:in `open'
    /var/lib/gems/3.1.0/gems/mini_magick-4.12.0/lib/mini_magick/image.rb:108:in `open'
    /home/vagrant/rails/activestorage/test/test_helper.rb:70:in `read_image'
    /home/vagrant/rails/activestorage/test/models/representation_test.rb:11:in `block in <class:RepresentationTest>'

bin/test test/models/representation_test.rb:7

Finished in 0.472072s, 2.1183 runs/s, 0.0000 assertions/s.
1 runs, 0 assertions, 0 failures, 1 errors, 0 skips
$

This commit addresses
the "MiniMagick::Invalid: You must have ImageMagick or GraphicsMagick installed" error.

- Steps to reproduce
```
vagrant ssh
git clone https://github.com/rails/rails
cd rails
bundle install
cd activestorage
bin/test test/models/representation_test.rb -n test_representing_an_image
```

- This commit addresses the following error:
```
$ bin/test test/models/representation_test.rb -n test_representing_an_image
... snip ...
E

Error:
ActiveStorage::RepresentationTest#test_representing_an_image:
MiniMagick::Invalid: You must have ImageMagick or GraphicsMagick installed
    /var/lib/gems/3.1.0/gems/mini_magick-4.12.0/lib/mini_magick/image.rb:221:in `rescue in validate!'
    /var/lib/gems/3.1.0/gems/mini_magick-4.12.0/lib/mini_magick/image.rb:218:in `validate!'
    /var/lib/gems/3.1.0/gems/mini_magick-4.12.0/lib/mini_magick/image.rb:131:in `block in create'
    <internal:kernel>:90:in `tap'
    /var/lib/gems/3.1.0/gems/mini_magick-4.12.0/lib/mini_magick/image.rb:130:in `create'
    /var/lib/gems/3.1.0/gems/mini_magick-4.12.0/lib/mini_magick/image.rb:34:in `read'
    /var/lib/gems/3.1.0/gems/mini_magick-4.12.0/lib/mini_magick/image.rb:108:in `block in open'
    /var/lib/gems/3.1.0/gems/mini_magick-4.12.0/lib/mini_magick/image.rb:108:in `open'
    /var/lib/gems/3.1.0/gems/mini_magick-4.12.0/lib/mini_magick/image.rb:108:in `open'
    /var/lib/gems/3.1.0/gems/mini_magick-4.12.0/lib/mini_magick/image.rb:108:in `open'
    /home/vagrant/rails/activestorage/test/test_helper.rb:70:in `read_image'
    /home/vagrant/rails/activestorage/test/models/representation_test.rb:11:in `block in <class:RepresentationTest>'

bin/test test/models/representation_test.rb:7

Finished in 0.472072s, 2.1183 runs/s, 0.0000 assertions/s.
1 runs, 0 assertions, 0 failures, 1 errors, 0 skips
$
```
@yahonda yahonda merged commit 418a308 into rails:master Jan 12, 2024
@yahonda yahonda deleted the add_imagemagick branch January 12, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant