Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruct removing Sprockets from Gemfile #79

Merged
merged 3 commits into from
Mar 7, 2022

Conversation

sedubois
Copy link
Contributor

@sedubois sedubois commented Mar 2, 2022

I suppose the upgrade guide introduced in #35 should instruct to remove Sprockets from the Gemfile?

Section 3 point 4 instructs to remove app/assets/config/manifest.js, which yields Sprockets::Railtie::ManifestNeededError when Sprockets is still present.

I suppose the upgrade guide introduced in rails#35 should instruct to remove Sprockets from the Gemfile?

Section 3 point 4 instructs to remove `app/assets/config/manifest.js`, which yields `Sprockets::Railtie::ManifestNeededError` when Sprockets is still present.
@brenogazzola
Copy link
Collaborator

Might be better to mention sprockets-rails too since #76 had a similar issue with it. I assumed a sprockets/webpacker project (which the guide is targeted at) would have sass-rails instead of any of the sprockets gems, but with more people raising the same point...

@sedubois
Copy link
Contributor Author

sedubois commented Mar 2, 2022

Yes, the only reason sprockets became an explicit dependency in our project was to temporarily pin its version before later allowing an upgrade to version 4.

@stevegeek
Copy link
Contributor

@sedubois Yeah something similar happened to me (just opened #81 with some other updates). Btw one suggestion here is maybe to change gemfile to Gemfile since I think it is mostly written capitalised.

@stevegeek stevegeek mentioned this pull request Mar 6, 2022
@brenogazzola brenogazzola merged commit 24ecd7d into rails:main Mar 7, 2022
@sedubois sedubois deleted the patch-1 branch March 7, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants