Skip to content

Conversation

@excid3
Copy link
Contributor

@excid3 excid3 commented Dec 3, 2021

Unique lists validates the new elements were not an empty list, but does not check for duplicate items in the array being passed in.

This makes removes any duplicates before passing them to Redis.

@excid3 excid3 force-pushed the deduplicate-new-elements branch from 8fa0f99 to d5857e3 Compare December 3, 2021 15:08
@kaspth
Copy link
Contributor

kaspth commented Dec 3, 2021

Discussed with @excid3 to remove the rare and untested flatten handling and let callers handle that.

@kaspth kaspth merged commit 8b77172 into rails:main Dec 3, 2021
@excid3 excid3 deleted the deduplicate-new-elements branch December 3, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants