Skip to content

Redundant limiter.poke in README.md #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2025
Merged

Redundant limiter.poke in README.md #141

merged 2 commits into from
Apr 19, 2025

Conversation

@ermolaev
Copy link
Contributor

@ermolaev ermolaev commented Jan 9, 2024 

limiter = Kredis.limiter "mylimit", limit: 3, expires_in: 5.seconds
7.times { pp [limiter.poke, limiter.exceeded?] }
[1, false]
[2, false]
[3, true]
[4, true]
[5, true]
[6, true]
[7, true]

jeremy
jeremy approved these changes Apr 19, 2025
View reviewed changes
Copy link
Member

@jeremy jeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it's >= not >.

@jeremy jeremy merged commit 41b5358 into rails:main Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeremy jeremy jeremy approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ermolaev @jeremy