Skip to content

Adds include? to ordered set #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 19, 2023
Merged

Adds include? to ordered set #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
42f075a
adds include? to ordered set
EduardoAntequera Aug 21, 2023
78f0d0d
check only if element is included
EduardoAntequera Aug 21, 2023
f1fd5a5
remove not needed assertion
EduardoAntequera Aug 21, 2023
a4378b8
Update lib/kredis/types/ordered_set.rb
EduardoAntequera Aug 23, 2023
ff9f127
add zscore to proxying
EduardoAntequera Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/kredis/types/ordered_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
class Kredis::Types::OrderedSet < Kredis::Types::Proxying
prepend Kredis::DefaultValues

proxying :multi, :zrange, :zrem, :zadd, :zremrangebyrank, :zcard, :exists?, :del
proxying :multi, :zrange, :zrem, :zadd, :zremrangebyrank, :zcard, :exists?, :del, :zscore

attr_accessor :typed
attr_reader :limit
Expand All @@ -17,6 +17,10 @@ def remove(*elements)
zrem(types_to_strings(elements, typed))
end

def include?(element)
!!zscore(type_to_string(element, typed))
end

def prepend(elements)
insert(elements, prepending: true)
end
Expand Down
7 changes: 7 additions & 0 deletions test/types/ordered_set_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@ class OrderedSetTest < ActiveSupport::TestCase
assert @set.exists?
end

test "include?" do
@set.append(%w[ 1 2 3 4 5 ])

assert @set.include?(1)
assert_not @set.include?(6)
end

test "appending over limit" do
@set.append(%w[ 1 2 3 4 5 ])
@set.append(%w[ 6 7 8 ])
Expand Down