Why don't we generate jbuilder templates for Rails 5? #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, Jbuilder also depends on activesupport "< 5". I'm not sure I'm comfortable announcing that Rails 5 is supported just yet, and that PR kind of does that. Could we at wait until they at least release a beta? I think we should. |
|
I'll leave this PR open and merge it to give credit once Rails 5 beta is available. |
|
@rwz Thank you for the consideration, but Gem::Version.new('5.0.0.alpha') < Gem::Version.new('5')
#=> true |
|
Alright, that makes sense. :) |
rwz
added a commit
that referenced
this pull request
Mar 7, 2015
Why don't we generate jbuilder templates for Rails 5?
|
Released 2.2.11 |
|
@rwz Thank you! 🌟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch has no test, but I confirmed that it works on my local rails/master app.