make multiline importmap definitions work with importmap outdated for instance
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or instance i had a package that kept being marked as outdated and thus my ci was failing
dorianmariecom
force-pushed
the
dorian/multiline-importmap
branch
from
34f47d5
to
4b126f6
Compare
|
Think better to document that for this to work things have to stay on a single line. There are all sorts of other formatting considerations one could imagine, and we're not going to deal with all of them via regexp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i had a package that kept being marked as outdated and thus my ci was failing