Handle String response for "find latest version"

[vietqhoang]

Closes #245

Problem

It is expected NPM to return a Hash for the response.

importmap-rails/lib/importmap/npm.rb

Line 89 in ddf9be4

latest_version = response.dig('dist-tags', 'latest')

But for whatever reason the response can now also return a String, which is not accounted for in npm.rb.

See the referenced issue for further context.

Expectation

The importmap outdated command should handle the problem more gracefully. In this case, a reasonable expectation is to surface the String response.

Solution

How to handle is up for discussion.

Just to get the fix process started the propose change is to surface the String in the response as latest_version since it isn't clear what the contents of the String could be.

Using the fork with change on our production app which has the problematic pinned dependency, the following outdated is now returned.

| Package                | Current | Latest                 |
|------------------------|---------|------------------------|
| @floating-ui/utils/dom | 0.2.1   | version not found: dom |
  1 outdated package found

[vietqhoang]

Not exactly sure why the CI checks are failing, but it seems to have nothing to do with the proposed changes.

[vietqhoang]

The response may be a blank String. One reported issue (#245 (comment)) made me question this possibility.

If this is the case then a fallback may be worthwhile. I am writing it with available Rails methods, but can change it to use Ruby-only accessible ones.

Suggested change

	latest_version = response.is_a?(String) ? response : response.dig('dist-tags', 'latest')
	latest_version = response.is_a?(String) ? (response.presence || 'unknown') : response.dig('dist-tags', 'latest')

[rbclark]

Any chance this fix could be merged or at least considered? Without this it's making it very hard for us to figure out which JS dependencies are out of date since we were relying heavily on the importmap outdated command to list them out for us.