Handle String response for "find latest version" #246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #245
Problem
It is expected NPM to return a Hash for the response.
importmap-rails/lib/importmap/npm.rb
Line 89 in ddf9be4
But for whatever reason the response can now also return a String, which is not accounted for in
npm.rb
.See the referenced issue for further context.
Expectation
The
importmap outdated
command should handle the problem more gracefully. In this case, a reasonable expectation is to surface the String response.Solution
How to handle is up for discussion.
Just to get the fix process started the propose change is to surface the String in the response as
latest_version
since it isn't clear what the contents of the String could be.Using the fork with change on our production app which has the problematic pinned dependency, the following
outdated
is now returned.