Skip to content

Accept Cache Key for Inline & Preloaded Module in Importmap Tag #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Accept Cache Key for Inline & Preloaded Module in Importmap Tag #176

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a59187
Accept Cache Key for Inline & Preloaded Module in Importmap Tag
rience Feb 19, 2023
68163ec
Fixing Tests
rience Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixing Tests
  • Loading branch information
@rience
rience committed Feb 20, 2023
commit 68163ec52b6351022619c9213cd8ec610ff55681
4 changes: 2 additions & 2 deletions test/importmap_tags_helper_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def content_security_policy_nonce
set_two = javascript_importmap_tags(inline_importmap_cache_key: 'inline-2')

assert_not_equal set_one, set_two
assert_match /assets\.example\.com/, javascript_importmap_tags(set_one)
assert_match /assets\.example\.com/, set_two
ensure
ActionController::Base.asset_host = nil
end
Expand All @@ -75,7 +75,7 @@ def content_security_policy_nonce
set_two = javascript_importmap_tags(module_preload_tags_cache_key: 'preload-2')

assert_not_equal set_one, set_two
assert_match /assets\.example\.com/, javascript_importmap_tags(set_one)
assert_match /assets\.example\.com/, set_two
ensure
ActionController::Base.asset_host = nil
end
Expand Down