Test invalid importmap file #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raising a custom error means it's a bit easier to track across error monitoring tools.
We usually don't want to rescue the base Exception class as these errors are reserved for things like a system interrupt. This commit swaps that out for rescuing a StandardErrorr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test to cover an invalid importmap file and makes use of a custom error class for easier error tracking.
While I was in there I noticed we're rescuing
Exceptions rather thanStandardErrors when parsing importmap files. That's interesting to me as it's usually something I avoid doing—Exceptions are raised by events like a system interrupt, which I imagine we wouldn't want to swallow. I'm happy to remove that commit if it's required though 😄