Skip to content

Conversation

@salzig
Copy link

@salzig salzig commented Oct 31, 2019

Was surprised that it's possible to overload the auto detection using just a variable. Hope it's ok to just state it at this prominent location in the readme.

@salzig
Copy link
Author

salzig commented Nov 3, 2019

  1) Failure:
TestExecJS#test_timers_are_undefined [test/test_execjs.rb:289]:
Expected false to be truthy.
  2) Failure:
TestExecJS#test_console_is_undefined [test/test_execjs.rb:284]:
Expected false to be truthy.

I'm pretty sure i didn't introduce this error by a readme change :)

@yagarea
Copy link

yagarea commented Sep 12, 2023

I vote for merging of this PR. This is very important and hard to find information

@byroot byroot closed this in 1dfec33 Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants