Merge pull request #120 from casperisfine/fix-anonymous-eval

Avoid anonymous eval
rails · Jan 11, 2023 · 1a61226 · 1a61226
2 parents e553b3f + 1c1770d
commit 1a61226
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/lib/execjs/external_runtime.rb b/lib/execjs/external_runtime.rb
@@ -103,7 +103,13 @@ def initialize(options)
       @popen_options[:internal_encoding] = ::Encoding.default_internal || 'UTF-8'
 
       if @runner_path
-        instance_eval generate_compile_method(@runner_path)
+        instance_eval <<~RUBY, __FILE__, __LINE__
+          def compile_source(source)
+            <<-RUNNER
+            #{IO.read(@runner_path)}
+            RUNNER
+          end
+        RUBY
       end
     end
 
@@ -143,15 +149,6 @@ def locate_executable(command)
       end
 
     protected
-      def generate_compile_method(path)
-        <<-RUBY
-        def compile_source(source)
-          <<-RUNNER
-          #{IO.read(path)}
-          RUNNER
-        end
-        RUBY
-      end
 
       def json2_source
         @json2_source ||= IO.read(ExecJS.root + "/support/json2.js")