Do not use 'return false' in AR callbacks for compatibility with Rails 5

[sudoremo]

The current implementation lead to DEPRECATION WARNINGs under Rails 5 and ultimately prevented records from being saved. If I interpret the code right, the return false statements are not meant for halting the whole saving chain but just mean to exit the method. I've replaced them with a simple return and everything appears to work.

Thanks a bunch for considering this.

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[rafaelfranca]

If they were returning false it was halting the callback chain so we need to keep the same behavior.

[sudoremo]

Ok, I've now changed it so that the behavior is now the same as before and still compatible with Rails 5.

[rafaelfranca]

Awesome! Thank you

[sudoremo]

Is there any news on this? Would be great if it could be merged. Thanks :)

[sudoremo]

Might I bump again here? Would be useful to have this released. Thanks a lot for considering it.

[robin850]

@remofritzsche : 4493a42 is part of the version 1.1.0 of this gem (which has been release on May, 11) so you should be able to use this patch in your application.