-
Notifications
You must be signed in to change notification settings - Fork 189
ruby 3x support #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ruby 3x support #521
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
#!/usr/bin/env bash | ||
# stop local dockerized development environment and clean build files | ||
|
||
set -x | ||
set +e | ||
|
||
docker compose down | ||
|
||
sudo rm ./Gemfile.lock | ||
sudo rm -rf ./tmp |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,4 +6,3 @@ Rake::TestTask.new do |t| | |
t.test_files = FileList['test/**/*_test.rb'] | ||
t.verbose = true | ||
end | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,21 @@ | ||
#!/usr/bin/env bash | ||
# grants circlci docker uid and gid required write permissions to project file system | ||
|
||
set -x | ||
|
||
sudo groupadd -g 3434 circleci_tinytds | ||
sudo usermod -a -G circleci_tinytds $USER | ||
sudo useradd circleci_tinytds -u 3434 -g 3434 | ||
sudo usermod -a -G circleci_tinytds circleci_tinytds | ||
sudo chgrp -R circleci_tinytds . | ||
if $(dpkg --compare-versions $ruby_version lt 3.1) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hm, all of this is a bit confusing. Is it to prepare for Ruby 3.1? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it was from the 3.1 work, yes. circleci changed the permissions in their container. i will stash this change for a future commit |
||
then | ||
sudo groupadd -g 3434 circleci_tinytds30 | ||
sudo useradd circleci_tinytds30 -u 3434 -g 3434 | ||
sudo usermod -a -G circleci_tinytds30 circleci_tinytds30 | ||
sudo usermod -a -G circleci_tinytds30 $USER | ||
sudo chgrp -R circleci_tinytds30 . | ||
else | ||
sudo groupadd -g 1002 circleci_tinytds31 | ||
sudo useradd circleci_tinytds31 -u 1001 -g 1002 | ||
sudo usermod -a -G circleci_tinytds31 circleci_tinytds31 | ||
sudo usermod -a -G circleci_tinytds31 $USER | ||
sudo chgrp -R circleci_tinytds31 . | ||
fi | ||
|
||
sudo chmod -R g+rwx . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the pro/con on this tag vs a more generic one, such as
2022-latest
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, i wondered if you had any thoughts about this
mssql 2022 came out this month. do you have a preference for 2022 or to stay on 2019-latest?
i suppose as long as 2022-latest passes everything, i don't see a reason not to test on it.