Bump public_suffix version range #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5.0 contains no breaking API changes, per https://github.com/weppos/publicsuffix-ruby/blob/main/CHANGELOG.md#500
|
any progress on this? |
|
@KoenSengers it may be time to think about a forking the gem for the project(s) you're using it with. Almost 1.5 years without a commit, and seems like radio silence from ROS. I had to create a private fork just to resolve this issue. CI is completely broken as well 🤷 . |
|
i think i will start doing that then, thx |
|
We're new maintainers! So we're definitely open to reviewing any PRs y'all got! Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.0 contains no breaking API changes, per https://github.com/weppos/publicsuffix-ruby/blob/main/CHANGELOG.md#500