Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate History.md #80

Closed
rpbaltazar opened this issue Jun 26, 2020 · 3 comments · Fixed by #90
Closed

Deprecate History.md #80

rpbaltazar opened this issue Jun 26, 2020 · 3 comments · Fixed by #90
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@rpbaltazar
Copy link
Contributor

Versions change log is already maintained in the releases. Having an History.md is added work for something that can be achieved by looking at the github releases
@rpbaltazar rpbaltazar added the documentation Improvements or additions to documentation label Jun 26, 2020
@rpbaltazar
Copy link
Contributor Author

After doing some more reading, this seems to be a better solution. Though github releases are a nice to have, having a changelog/history makes more sense for historic reasons.

I shall make some experiments with this
https://github.com/marketplace/actions/automatic-changelog-generator

rpbaltazar added a commit that referenced this issue Jul 12, 2020
@rpbaltazar
[#80] added changelog action
d5aa476
rpbaltazar added a commit that referenced this issue Jul 12, 2020
@rpbaltazar
[#80] updated action
31eacfc
rpbaltazar added a commit that referenced this issue Jul 12, 2020
@rpbaltazar
[#80] ran automatic changelog generator to create changelog file
8439c85
@rpbaltazar rpbaltazar added the enhancement New feature or request label Jul 12, 2020
rpbaltazar added a commit that referenced this issue Jul 12, 2020
@rpbaltazar
[#80] made history md compatible with changelog automation
2a6b6d3
rpbaltazar added a commit that referenced this issue Jul 12, 2020
@rpbaltazar
[#80] added changelog action
99dfda8
rpbaltazar added a commit that referenced this issue Jul 12, 2020
@rpbaltazar
[#80] updated action
b506bc7
rpbaltazar added a commit that referenced this issue Jul 12, 2020
@rpbaltazar
[#80] ran automatic changelog generator to create changelog file
ea14412
rpbaltazar added a commit that referenced this issue Jul 12, 2020
@rpbaltazar
[#80] made history md compatible with changelog automation
49ab159
@rpbaltazar rpbaltazar linked a pull request Jul 12, 2020 that will close this issue
[Resolves #80] added changelog action #90
Merged
@rpbaltazar
Copy link
Contributor Author

We're now using github actions to generate the changelog.md.
Once confirmed that the flow is working for us, we'll be removing the history.md file

@rpbaltazar rpbaltazar mentioned this issue Jul 17, 2020
Merged
@BobbyMcWho
Copy link

It seems like the auto-changelog is broken? missing at least 3 minor releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Resolves #80] added changelog action rails-on-services/apartment
2 participants
@rpbaltazar @BobbyMcWho