Support EventBridge Events #82
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually we want to move to this interface all the time in
app.rb. Our goal is to reflect on the incoming event and do everything right as needed.We are mature enough to know what HTTP events look like and can instantiate the proper Rack adapter as needed. This means we can also move away from code like this in the Lambdakiq gem.
When it comes to EventBridge, we can not assume the details in the message knows now to instantiate model objects or invoke tasks. As such, we simply add a default proc that applications can customize. For example in
application.rb:You can also set this configuration to
Lamby.config.event_bridge_handlerto false to disable this feature all together.