Allow referencing sideloaded include by key.
#2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that associations with a key set are still included.
bf4
requested changes
May 17, 2017
mtwentyman
reviewed
May 17, 2017
| assert_nil(hash[:included]) | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
this (extra empty) line is what rubocop doth complain about
|
@caomania merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When an association is set to be
sideloadedand the association has akeydefined we should be able to include this association by referencing thekey.Changes
When checking
include_slicefor associations to include, check the association'skeyoption first, then fallback to the associationname.Additional helpful information
Added tests to demonstrate that attempting to reference an association by
keywhen including associations currently fails.