Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upgrade_from_0_8_to_0_10.md #1933

Merged
merged 2 commits into from
Sep 20, 2016
Merged

Conversation

brendon
Copy link
Contributor

@brendon brendon commented Sep 19, 2016

Purpose

Clarify the change in the way relationships are walked in 0.10.

Changes

Added an explanation to the upgrade documentation.

Caveats

Related GitHub issues

#1127

Additional helpful information

Just proposing a change to the upgrade guide to highlight the change in the way relationships are walked. Let me know if any of the details are wrong.

Just proposing a change to the upgrade guide to highlight the change in the way relationships are walked. Let me know if any of the details are wrong.
@mention-bot
Copy link

@brendon, thanks for your PR! By analyzing the annotation information on this pull request, we identified @bkoltai and @bf4 to be potential reviewers

@richmolj
Copy link
Contributor

@brendon LGTM. Could you squash these commits?

@NullVoxPopuli
Copy link
Contributor

@richmolj we can squash ourselves

@NullVoxPopuli
Copy link
Contributor

github has a button for that. "Squash and merge"

@richmolj richmolj merged commit 0606b06 into rails-api:master Sep 20, 2016
@richmolj
Copy link
Contributor

@NullVoxPopuli never realized that, thanks!

@brendon brendon deleted the patch-1 branch September 20, 2016 21:00
@brendon
Copy link
Contributor Author

brendon commented Sep 20, 2016

Thanks @richmolj :) @NullVoxPopuli, I never was able to get the global configuration for include to work, but ended up not needing it in my project in the end. Hopefully it was just a quirk for me.

@richmolj
Copy link
Contributor

@brendon afaik the global configuration is only referenced within the jsonapi adapter.

@brendon
Copy link
Contributor Author

brendon commented Sep 20, 2016

Ah righty, that makes sense then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants