-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add helpful testing gems #1913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helpful testing gems #1913
Conversation
|
@richmolj, thanks for your PR! By analyzing the annotation information on this pull request, we identified @bf4, @steveklabnik and @beauby to be potential reviewers |
869631e to
785c4a1
Compare
test/test_helper.rb
Outdated
| STDERR.puts 'Running without SimpleCov' | ||
| end | ||
|
|
||
| begin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you just require pry, it will load all pry plugins. This will lead to less churn if/when we add more pry configurations. I won't block if this doesn't seem interesting to you. It would require adding pry to the gemfile, then we could remove the rescue here since pry is all platforms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure ill give that a shot
| gem 'activerecord-jdbcsqlite3-adapter', platform: :jruby | ||
| gem 'codeclimate-test-reporter', require: false | ||
| gem 'm', '~> 1.5' | ||
| gem 'pry', '~> 0.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, put in pry-byebug as well, just limit it to valid platforms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, duh, yes of course. updated, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what advantage does adding pry provide? I thought pry-byebug included it.
| STDERR.puts 'Running without SimpleCov' | ||
| end | ||
|
|
||
| require 'pry' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be require 'pry-byebug'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was actually a great suggestion by @bf4 - if you require 'pry' it will load any pry plugins for you. So if you are non-MRI you will only get pry (works across rubies), if you are MRI you get pry-byebug as well (both specified in Gemfile).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neato
Adds gems m (run minitest by line numbers like rspec) and pry-byebug (for binding.pry support).
Addresses #1911 (comment)