Organize Serializer concerns into concerns/ #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bf4, thanks for your PR! By analyzing the annotation information on this pull request, we identified @beauby, @bolshakov and @zaaroth to be potential reviewers |
|
imafan.jpg |
|
(I've also had the same issue) |
|
I think one small further / next step would be to differentiate between the relationship hierarchy, and everything else. |
|
but that requires class/module namespace changing... and ... blegh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep losing track of which things in the serializer/ folder
are part of the serializer that have been put in their own 'concern' file
and which files represent their own object.
Related to #1857 and #1897