Remove default key case change message #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| spec.post_install_message = <<-EOF | ||
| NOTE: The default key case for the JsonApi adapter has changed to dashed. | ||
| See https://github.com/rails-api/active_model_serializers/blob/master/docs/general/key_transforms.md | ||
| for more information on configuring this behavior. |
There was a problem hiding this comment.
might want to include that it's a performance hit, and to use ActiveModelSerializers.config.key_transform = :unaltered if you don't need it :)
There was a problem hiding this comment.
does that need to be in the post install message though? or our docs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Removes the post install message that warned the default key case for the
json_apiadapter had changed.