Encourage pinning of pre-1.0.0 release [skip ci] #1741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisleech
force-pushed
the
pin-gem-version
branch
from
469d2bb to
e30039a
Compare
|
I'm not opposed to that. It's a good habit to have if people want to be able to do @bf4, thoughts? |
| @@ -56,7 +56,7 @@ It is generally safe and recommended to use the master branch. | |||
| Add this line to your application's Gemfile: | |||
|
|
|||
| ``` | |||
| gem 'active_model_serializers' | |||
| gem 'active_model_serializers', '~> 0.10.0' | |||
There was a problem hiding this comment.
seems like a good idea. There's been discussion of doing something similar to what Rake and Node.js have done and jump to 10.0 (I'm for it), but it hasn't been resolved yet. pre-1.0 semver is weird.
@krisleech Thanks for sharing this PR. Anything else you might contribute back to help out others is much appreciated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Encourage the pinning of pre-1.0.0 release of this gem.
0.10 introduced breaking changes (notably, no root node is included in the JSON). This broke our build. Since semver allows pre-1.0.0 to introduce breaking changes this is okay. However since the gem is 5 years old but has no 1.0 release maybe we should encourage the pinning of the gem in the README.
Changes
Documentation only.
Caveats
Related GitHub issues
Additional helpful information