Support conditional setting of serialization_scope in controllers #1711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogeshjain999
force-pushed
the
conditional_serialization_scope
branch
from
e89c5e6 to
036d68d
Compare
|
I like it. I need to look at the test changes a bit. |
| @@ -71,10 +77,12 @@ class DefaultScopeTest < ActionController::TestCase | |||
| tests PostTestController | |||
|
|
|||
| def test_default_serialization_scope | |||
| get :render_post | |||
There was a problem hiding this comment.
this is supposed to be missing in this test :)
|
Closing as stale. No response in a month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I want to set
serialization_scopeas different object rather thancurrent_user, for only specific actions in given controller.Changes
Adds support for setting
serialization_scopeconditionally in controllers, same as callingbefore_actionwith options.