Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output examples for the adapters #1375

Conversation

duduribeiro
Copy link

This PR will add output examples for the adapters (Default, Json, JsonApi).

If this is not correct, just tell me and I can change it =D

Thanks, 🍻

Closes #1314

@duduribeiro
Copy link
Author

Just one little question. The adapters.md page tells
render @posts, include: ['authors', 'comments']
Is the correct render json: @posts, include: ['authors', 'comments']
thanks =)

@bf4
Copy link
Member

bf4 commented Dec 15, 2015

@duduribeiro Awesome! 👍

I wonder if there's a way to make the examples easier to compare.

Is the correct render json: @posts

Yes :)

@bf4
Copy link
Member

bf4 commented Dec 15, 2015

I'd also love if you took a look at my documentation PR which moves around a whole bunch of things #1371

@duduribeiro
Copy link
Author

Nice @bf4 =D.. I will think if we can display in a better way.

to fix render json: @posts, I do it on this PR or in another?

I will see your PR \o/

cheers. 🍻

@beauby
Copy link
Contributor

beauby commented Dec 20, 2015

@duduribeiro Thanks for your work! I believe when you generate your examples you forgot to define a serializer for the authors though (which leads to inconsistent format, especially in the JSON API case). Could you fix it?

@beauby
Copy link
Contributor

beauby commented Dec 27, 2015

Hey @duduribeiro, any news on this?

@duduribeiro
Copy link
Author

Hey @beauby.. I'll check this \o

@remear
Copy link
Member

remear commented Mar 15, 2016

Hey, @duduribeiro. Are you still interested in wrapping this one up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants